Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-12] Added Ability to re-queue agenda Items. #87

Closed

Conversation

sanjaydemansol
Copy link
Contributor

Fixes #12

Summary

  • Now old agenda items could be re-queued to upcoming meetings.

Testing notes

  • Create multiple agenda items for past date according to channel Hash Format.(You may create a message and edit its date manually)
  • open RHS menu on any of these and click Re-queue
    Screenshot_78
    Result:
    It will be requeued to upcoming meeting date.
    Screenshot_79

Ticket Link

#12

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #87 (3ac3da8) into master (2f22484) will decrease coverage by 3.33%.
The diff coverage is 7.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   26.03%   22.69%   -3.34%     
==========================================
  Files           7        7              
  Lines         315      423     +108     
==========================================
+ Hits           82       96      +14     
- Misses        216      309      +93     
- Partials       17       18       +1     
Impacted Files Coverage Δ
server/command.go 0.00% <0.00%> (ø)
server/utils.go 62.74% <0.00%> (-31.20%) ⬇️
server/meeting.go 62.06% <50.00%> (-0.98%) ⬇️
server/main.go 0.00% <0.00%> (ø)
server/manifest.go 100.00% <0.00%> (ø)
server/configuration.go 0.00% <0.00%> (ø)
server/plugin.go 25.74% <0.00%> (+3.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f22484...3ac3da8. Read the comment docs.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 31, 2021
@jfrerich jfrerich requested a review from mickmister August 31, 2021 14:37
@jfrerich jfrerich added the 3: QA Review Requires review by a QA tester label Aug 31, 2021
prefix = matchGroups[1]
hashtagDateFormat = strings.TrimSpace(matchGroups[2])
} else {
return responsef("Error 203")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious what Error 203 means. Maybe we could make it more easier to understand.

@dipak-demansol
Copy link

dipak-demansol commented Sep 15, 2021

@sanjaydemansol
i tested, im able to re-queue the old agenda and if i try to re-queue the agenda of future date then i'm getting the message as "Re-queue future items are not supported." so its right but there is 1 issue.

issue :- today date is 15/9/21 wed, there was a agenda created at sep-9-21 and from the agenda setting i selected Friday to create next agenda and i Re-queue the sep-9-21 agenda so the next date should assign as sep-17-21 Friday but the wrong date assigned as sep-24-21 Friday. if the old agenda date is sep-3-21 Friday or sep-10-21 Friday and my feature meeting day is Friday and i re-queue that date agenda then next date is assigned sep 24-21 but it should assign sep-17-21.

@dipak-demansol dipak-demansol added QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer QA Review Done PR has been approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-queue an item for next meeting
5 participants