Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update withdrawal delay information #220

Merged
merged 10 commits into from
Feb 19, 2025

Conversation

tx-nikola
Copy link

This PR fixes #219

@tx-nikola tx-nikola added the enhancement New feature or request label Feb 14, 2025
@tx-nikola tx-nikola requested a review from bxpana February 14, 2025 14:49
@tx-nikola tx-nikola self-assigned this Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

Visit the preview URL for this PR (updated for commit 2c00f29):

https://staging-zksync-dapp-wallet-v2--pr220-tx-nikola-txfusio-252ct78p.web.app

(expires Wed, 26 Feb 2025 21:01:22 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a25831e6058958ccabf0f806505b5b8e7241b178

@tx-nikola tx-nikola requested a review from popzxc February 14, 2025 15:05
@itsacoyote
Copy link

Does this line also need to be updated?

export const WITHDRAWAL_DELAY = 24 * 60 * 60 * 1000; // 24 hours

@tx-nikola
Copy link
Author

Does this line also need to be updated?

export const WITHDRAWAL_DELAY = 24 * 60 * 60 * 1000; // 24 hours

Yes - will update it as well. Initially I wasn't sure if it would mess up any other flows, but seems to be fine, so I'll update it.

@tx-nikola
Copy link
Author

@bxpana Updated it based on the comments

Update to 5 hours to account for extra time to execute
Update to 5 hours to account for extra time to execute
Update to 5 hours to account for extra time to execute
Update to 5 hours to account for extra time to execute
Update to 5 hours to account for extra time to execute
Update to 5 hours to account for extra time to execute
Copy link

@bxpana bxpana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go, made changes from 3 to 5 to account for time to batch batches for execution which can take a little more than the 3 hours.

@bxpana bxpana merged commit 8751bc1 into main Feb 19, 2025
4 checks passed
@bxpana bxpana deleted the tx-nikola-txfusion-update-withdrawal-delay-information branch February 19, 2025 21:03
Copy link

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Withdrawal Delay Information
3 participants