Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beeping sound keeps playing, even after exiting the vehicle #176

Closed
Druganov1 opened this issue Dec 18, 2023 · 3 comments
Closed

Beeping sound keeps playing, even after exiting the vehicle #176

Druganov1 opened this issue Dec 18, 2023 · 3 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Druganov1
Copy link

Druganov1 commented Dec 18, 2023

I was tired of els-plus having countless bugs, so i switched to this one, however there are some concerning bugs that should be fixed.

1. Warning beep keeps playing indefinetly after exiting vehicle.

The first thing that was really annoying is that once you turn the stop sign on (REARREDS) and the warning beep is ticked, even if you exit the vehicle you will hear that beep untill you leave the server, or get into another car that has ELS, and toggle the stop sign.

2. When you spawn a ELS vehicle, every extra is enabled by default

The second very annoying thing that i discovered is that the moment you spawn a els vehicle, that you configured the VCF for, every extra on the vehicle will be enabled by default, i know this is not a bug in the resource itself as this is just build into FiveM, it would be nice to turn every extra off the moment someone sits in a vehicle for the first time.

@JustinRijsdijk
Copy link
Collaborator

Hi there @Druganov1 , at first, thanks for using miss-ELS! Thanks for submitting your issues. This helps us making MISS-ELS better!

Regarding your issues with the warning beep, we already have an outstanding issue on the current roadmap. Please see #173 if I'm not mistaken.

Regarding your point about all extras being on by default. I heard of a possible fix/workaround using the vehicle meta. I have not yet confirmed this myself, but it might be worth checking out; In your 'flags' section of your vehicles' meta file. There should be a flag called 'FLAG_EXTRAS_REQUIRE'. Can you try changing that into 'FLAG_EXTRAS_SCRIPT'? Please be sure to restart your server afterwards.

Please report back if this is indeed a fix/workaround for now.

@Druganov1
Copy link
Author

Druganov1 commented Dec 19, 2023

Hi there @Druganov1 , at first, thanks for using miss-ELS! Thanks for submitting your issues. This helps us making MISS-ELS better!

Regarding your issues with the warning beep, we already have an outstanding issue on the current roadmap. Please see #173 if I'm not mistaken.

Regarding your point about all extras being on by default. I heard of a possible fix/workaround using the vehicle meta. I have not yet confirmed this myself, but it might be worth checking out; In your 'flags' section of your vehicles' meta file. There should be a flag called 'FLAG_EXTRAS_REQUIRE'. Can you try changing that into 'FLAG_EXTRAS_SCRIPT'? Please be sure to restart your server afterwards.

Please report back if this is indeed a fix/workaround for now.

Hello there!

I have fixed every issue i named, made some improvements in the code itself,

Regarding that all the extras were on, i also fixed that within MISS-ELS.

How can i share the changes?

@Druganov1 Druganov1 reopened this Dec 19, 2023
@matsn0w
Copy link
Owner

matsn0w commented Dec 19, 2023

Hi, great to hear that your problems are fixed.

If you want to contribute, you can open a Pull Request with your code changes. We will review it and if approved, your code will be merged into our codebase. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request for a detailed explanation.

@matsn0w matsn0w added bug Something isn't working duplicate This issue or pull request already exists labels Dec 19, 2023
@matsn0w matsn0w closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants