Add Server to Access-Control-Expose-Headers header (#15908)

matrix-org · Jul 11, 2023 · b516d91 · b516d91
1 parent 2328e90
commit b516d91
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/changelog.d/15908.misc b/changelog.d/15908.misc
@@ -0,0 +1 @@
+Add `Server` to Access-Control-Expose-Headers header.
diff --git a/synapse/http/server.py b/synapse/http/server.py
@@ -910,7 +910,7 @@ def set_cors_headers(request: SynapseRequest) -> None:
         )
         request.setHeader(
             b"Access-Control-Expose-Headers",
-            b"Synapse-Trace-Id",
+            b"Synapse-Trace-Id, Server",
         )
 
 

diff --git a/tests/test_server.py b/tests/test_server.py
@@ -268,7 +268,7 @@ def _check_cors_standard_headers(self, channel: FakeChannel) -> None:
         )
         self.assertEqual(
             channel.headers.getRawHeaders(b"Access-Control-Expose-Headers"),
-            [b"Synapse-Trace-Id"],
+            [b"Synapse-Trace-Id, Server"],
         )
 
     def _check_cors_msc3886_headers(self, channel: FakeChannel) -> None: