Don't ban users in moderator room #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
requested changes
Oct 10, 2024
src/Mjolnir.ts
Outdated
| /** | ||
| * Members of the moderator room and others who should not be banned, ACL'd etc. | ||
| */ | ||
| public moderators: string[]; |
There was a problem hiding this comment.
Users who are invited/joined after the bot starts up would get banned. Adding a cache would help ensure we don't miss anyone. We'd invalidate the cache on two conditions I think:
- Every 60 minutes.
- Whenever we see an
m.room.memberevent in the management room. (we don't have to inspect the event: seeing it fly by should be enough to invalidate&repopulate)
For deployments like matrix.org this may mean we pick up on displayname changes quite often, but I'd consider that a feature for keeping the cache active.
H-Shay
force-pushed
the
shay/no_self_harm
branch
from
d5e7fc8
to
fac9f2d
Compare
turt2live
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the bot from banning itself/other users in the moderator room. Also adds a command to add others who are not in room to list of entities that shouldn't be banned/ACL'd.
Reviewable commit-by-commit.