Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bert model function m-help should explain what "parameters" input is #24

Open
vpapanasta opened this issue Feb 23, 2022 · 1 comment
Open
Labels
documentation Improvements or additions to documentation

Comments

@vpapanasta
Copy link
Member

No description provided.

@bwdGitHub bwdGitHub added the documentation Improvements or additions to documentation label Feb 23, 2022
@bwdGitHub
Copy link
Collaborator

Yeah we could at least say parameters should be mdl.Parameters where mdl = bert(...). We don't mention this in the readme either.

Of course you could create parameters from scratch too, but I never added a handy function to do that. And the FinBERT parameters should work too (see finbert.model is just a simple wrapper to bert.model). So I'd want to somehow say using mdl=bert(...) is sufficient but not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants