chore: fix sonar issues

mathuo · Dec 10, 2024 · e230237 · e230237
1 parent f13f009
commit e230237
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 14 deletions.
diff --git a/packages/dockview-core/src/dockview/dockviewComponent.ts b/packages/dockview-core/src/dockview/dockviewComponent.ts
@@ -767,15 +767,16 @@ export class DockviewComponent
 
                 let returnedGroup: DockviewGroupPanel | undefined;
 
+                const isValidReferenceGroup =
+                    isGroupAddedToDom &&
+                    referenceGroup &&
+                    this.getPanel(referenceGroup.id);
+
                 const value = {
                     window: _window,
                     popoutGroup: group,
-                    referenceGroup: !isGroupAddedToDom
-                        ? undefined
-                        : referenceGroup
-                        ? this.getPanel(referenceGroup.id)
-                            ? referenceGroup.id
-                            : undefined
+                    referenceGroup: isValidReferenceGroup
+                        ? referenceGroup.id
                         : undefined,
                     disposable: {
                         dispose: () => {

diff --git a/packages/dockview-core/src/gridview/baseComponentGridview.ts b/packages/dockview-core/src/gridview/baseComponentGridview.ts
@@ -1,10 +1,5 @@
 import { Emitter, Event, AsapEvent } from '../events';
-import {
-    getGridLocation,
-    Gridview,
-    IGridView,
-    MaximizedViewChanged,
-} from './gridview';
+import { getGridLocation, Gridview, IGridView } from './gridview';
 import { Position } from '../dnd/droptarget';
 import { Disposable, IDisposable, IValueDisposable } from '../lifecycle';
 import { sequentialNumberGenerator } from '../math';
@@ -13,7 +8,6 @@ import { IPanel } from '../panel/types';
 import { MovementOptions2 } from '../dockview/options';
 import { Resizable } from '../resizable';
 import { Classnames } from '../dom';
-import { IGridviewComponent } from './gridviewComponent';
 
 const nextLayoutId = sequentialNumberGenerator();
 

diff --git a/packages/dockview-core/src/popoutWindow.ts b/packages/dockview-core/src/popoutWindow.ts
@@ -160,7 +160,7 @@ export class PopoutWindow extends CompositeDisposable {
                     resolve(container);
                 } catch (err) {
                     // only except this is the DOM isn't setup. e.g. in a in correctly configured test
-                    reject(err);
+                    reject(err as Error);
                 }
             });
         });