Merge pull request #346 from mathuo/344-floating-tab-groups-move-in-b…

…ested-dockview bug: skip resize for unmounted elements
mathuo · Oct 1, 2023 · a96400d · a96400d
2 parents 9006fb9 + 19595f3
commit a96400d
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/packages/dockview-core/src/resizable.ts b/packages/dockview-core/src/resizable.ts
@@ -29,6 +29,16 @@ export abstract class Resizable extends CompositeDisposable {
                      */
                     return;
                 }
+
+                if (!document.body.contains(this._element)) {
+                    /**
+                     * since the event is dispatched through requestAnimationFrame there is a small chance
+                     * the component is no longer attached to the DOM, if that is the case the dimensions
+                     * are mostly likely all zero and meaningless. we should skip this case.
+                     */
+                    return;
+                }
+
                 const { width, height } = entry.contentRect;
                 this.layout(width, height);
             })