bug: disable iframes within shadowdom during dnd

mathuo · Dec 10, 2024 · 53a59c5 · 53a59c5
1 parent 4291774
commit 53a59c5
Showing 1 changed file with 27 additions and 5 deletions.
diff --git a/packages/dockview-core/src/dom.ts b/packages/dockview-core/src/dom.ts
@@ -112,8 +112,11 @@ export function isAncestor(
     return false;
 }
 
-export function getElementsByTagName(tag: string): HTMLElement[] {
-    return Array.prototype.slice.call(document.getElementsByTagName(tag), 0);
+export function getElementsByTagName(
+    tag: string,
+    document: ParentNode
+): HTMLElement[] {
+    return Array.prototype.slice.call(document.querySelectorAll(tag), 0);
 }
 
 export interface IFocusTracker extends IDisposable {
@@ -288,10 +291,29 @@ export function addTestId(element: HTMLElement, id: string): void {
     element.setAttribute('data-testid', id);
 }
 
-export function disableIframePointEvents() {
+export function disableIframePointEvents(rootNode: ParentNode = document) {
+    const includeShadowDom = true;
+
+    const shadowRoots = [];
+
+    if (includeShadowDom) {
+        const items = rootNode.querySelectorAll('*');
+
+        for (let i = 0; i < items.length; i++) {
+            const item = items[i];
+            if (item.shadowRoot) {
+                shadowRoots.push(item.shadowRoot);
+            }
+        }
+    }
+
     const iframes: HTMLElement[] = [
-        ...getElementsByTagName('iframe'),
-        ...getElementsByTagName('webview'),
+        ...getElementsByTagName('iframe', rootNode),
+        ...getElementsByTagName('webview', rootNode),
+        ...shadowRoots.flatMap((root) => [
+            ...getElementsByTagName('iframe', root),
+            ...getElementsByTagName('webview', root),
+        ]),
     ];
 
     const original = new WeakMap<HTMLElement, string>(); // don't hold onto HTMLElement references longer than required