Skip to content

Commit

Permalink
Merge pull request #802 from mathuo/801-disposable-fix
Browse files Browse the repository at this point in the history
chore: adjust dockview disposable
  • Loading branch information
mathuo authored Dec 22, 2024
2 parents 8650de9 + 4d01d4e commit 487d02b
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions packages/dockview-core/src/dockview/dockviewComponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -577,11 +577,6 @@ export class DockviewComponent
this.updateWatermark();
}

override dispose(): void {
this.clear(); // explicitly clear the layout before cleaning up
super.dispose();
}

override setVisible(panel: DockviewGroupPanel, visible: boolean): void {
switch (panel.api.location.type) {
case 'grid':
Expand Down

0 comments on commit 487d02b

Please sign in to comment.