Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm64 support #162

Merged
merged 2 commits into from
Dec 30, 2024
Merged

arm64 support #162

merged 2 commits into from
Dec 30, 2024

Conversation

mathieu-benoit
Copy link
Owner

@mathieu-benoit mathieu-benoit commented Dec 30, 2024

Tests with:

  • Other PR: arm64 #137.
  • docker build .
  • docker build --platform linux/arm64
  • docker build --platform linux/amd64

oras manifest fetch ghcr.io/mathieu-benoit/my-sample-workload:test:

{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:f6d97472cd25f02f9413ec5217d373d1fcf4d9aa24ad829a71055e22e446428e",
      "size": 1048,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:38348f6e9b52544b77d80800000526c728ce97bc66db44d5e03fdab7043c3845",
      "size": 1048,
      "platform": {
        "architecture": "arm64",
        "os": "linux"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:75aaafea9befce846dbaf87a30826a195eb174c69fcfcf5f2097c3334eeb57ef",
      "size": 567,
      "annotations": {
        "vnd.docker.reference.digest": "sha256:f6d97472cd25f02f9413ec5217d373d1fcf4d9aa24ad829a71055e22e446428e",
        "vnd.docker.reference.type": "attestation-manifest"
      },
      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }
    },
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:2a03475e11b4b40e7f0dd53e99b4fb15eb58b2e3694e9b9ae4bff89c5bc4381b",
      "size": 567,
      "annotations": {
        "vnd.docker.reference.digest": "sha256:38348f6e9b52544b77d80800000526c728ce97bc66db44d5e03fdab7043c3845",
        "vnd.docker.reference.type": "attestation-manifest"
      },
      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }
    }
  ]
}

Note: I needed to remove --no-restore in the dotnet pulish command otherwise getting this error: /usr/share/dotnet/sdk/9.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(495,5): error NETSDK1112: The runtime pack for Microsoft.AspNetCore.App.Runtime.linux-x64 was not downloaded. Try running a NuGet restore with the RuntimeIdentifier 'linux-x64'. [/app/my-sample-app.csproj].

@mathieu-benoit mathieu-benoit mentioned this pull request Dec 30, 2024
Repository owner deleted a comment from github-actions bot Dec 30, 2024
Copy link

Deployment successfully completed for PR-162! 🎉

➡️ Open Resource Graph

🔍 View Deployment in Humanitec

🔗 my-sample-workload: muellerheidenreichhilpertjacobi.mabenoit.newapp.io

Deployment diff

Deployment diff:

{
  "modules": {
    "add": null,
    "remove": [],
    "update": {
      "my-sample-workload": [
        {
          "from": "",
          "op": "add",
          "path": "/spec/containers/my-sample-container/variables/POD_NAME",
          "value": "${pod.metadata.name}"
        },
        {
          "from": "",
          "op": "add",
          "path": "/spec/containers/my-sample-container/variables/NAMESPACE_NAME",
          "value": "${pod.metadata.namespace}"
        },
        {
          "from": "",
          "op": "replace",
          "path": "/spec/containers/my-sample-container/image",
          "value": "us-east4-docker.pkg.dev/mathieu-benoit-gcp/containers/my-sample-workload@sha256:441908a42708ad49284dd1d75c1371c03ed333df08bf187af5b909cc3c7b319a"
        },
        {
          "from": "",
          "op": "add",
          "path": "/spec/annotations/humanitec.io~1workload-source",
          "value": "https://github.com/mathieu-benoit/sail-sharp/blob/arm64-support/score/score.yaml"
        },
        {
          "from": "",
          "op": "remove",
          "path": "/spec/nodeSelector",
          "value": null
        }
      ]
    }
  },
  "shared": null
}
Active Resources Usage

Active Resources Usage:


ResType            	Class  	ResID                                     	Usage         	Last referencing deployment	Last referencing deployment created ago
agent              	default	agent                                     	current deploy	18160d7a5672aec7           	41.175691198s                          
base-env           	default	base-env                                  	current deploy	18160d7a5672aec7           	41.175693092s                          
k8s-cluster        	default	k8s-cluster                               	current deploy	18160d7a5672aec7           	41.175694234s                          
k8s-namespace      	default	k8s-namespace                             	current deploy	18160d7a5672aec7           	41.175695236s                          
logging            	default	logging                                   	current deploy	18160d7a5672aec7           	41.175696398s                          
k8s-service-account	default	modules.my-sample-workload                	current deploy	18160d7a5672aec7           	41.17569738s                           
workload           	default	modules.my-sample-workload                	current deploy	18160d7a5672aec7           	41.175698392s                          
dns                	default	modules.my-sample-workload.externals.dns  	current deploy	18160d7a5672aec7           	41.175699363s                          
ingress            	default	modules.my-sample-workload.externals.dns  	current deploy	18160d7a5672aec7           	41.175700496s                          
tls-cert           	default	modules.my-sample-workload.externals.dns  	current deploy	18160d7a5672aec7           	41.175701458s                          
route              	default	modules.my-sample-workload.externals.route	current deploy	18160d7a5672aec7           	41.175702379s                          
config             	default	tf-runner                                 	current deploy	18160d7a5672aec7           	41.175703311s                          

Active Resources diff

Active Resources diff:

23,33d22
<   "config",
<   "dns-wildcard",
<   "default",
<   "humanitec/template",
<   "test-wilcard-dns-config",
<   "69cce43c-3f9d-4b32-950e-1862e9638272",
<   {
<     "domain": "my-domain-for-dev"
<   }
< ]
< [
57c46
<     "namespace": "my-sample-app-development"
---
>     "namespace": "my-sample-app-pr-162"
72,93d60
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload",
<   "default",
<   "humanitec/template",
<   "custom-hpa",
<   "718c0b13-c617-429f-804a-75a3ab746a02",
<   {}
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload",
<   "implicit",
<   "humanitec/template",
<   "hpa-implicit",
<   "58c9b5ae-c909-4b78-a3c0-00f31864fcde",
<   {
<     "maxReplicas": "3",
<     "minReplicas": "2",
<     "targetCPUUtilizationPercentage": "80"
<   }
< ]
< [
123c90
<     "host": "murazikgreenholtgreenholt.mabenoit.newapp.io"
---
>     "host": "muellerheidenreichhilpertjacobi.mabenoit.newapp.io"
134c101
<     "id": "7bdb1397b2374c3d8fc251b8bc3c0e221de2a2cc-ingress",
---
>     "id": "ae369f61918e88be259c109d841a301ac7541136-ingress",
146,177c113
<     "tls_secret_name": "8da26d868e5349f401c0df7095ef3e01f84a53e1-tls"
<   }
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload.externals.hpa",
<   "default",
<   "humanitec/template",
<   "hpa-template",
<   "34d449a1-c34d-41c5-881a-5d8c950a7573",
<   {}
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload.externals.hpa-driver",
<   "hpa-driver",
<   "humanitec/hpa",
<   "hpa",
<   "4950d15d-7585-469d-b706-6975d246cdc8",
<   {}
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload.externals.hpa-score",
<   "default",
<   "humanitec/template",
<   "hpa-explicit",
<   "7a5caff7-5c53-4ca9-817d-d2ec5da5f103",
<   {
<     "maxReplicas": "3",
<     "minReplicas": "2",
<     "targetCPUUtilizationPercentage": "80"
---
>     "tls_secret_name": "11a8e1c3aa23ffe9478f337859aa3ba2f236a29b-tls"
188c124
<     "host": "murazikgreenholtgreenholt.mabenoit.newapp.io",
---
>     "host": "muellerheidenreichhilpertjacobi.mabenoit.newapp.io",
192,217d127
<   }
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload.externals.test",
<   "default",
<   "humanitec/template",
<   "hpa-explicit",
<   "495e24e2-4e97-4994-a02f-a0a905801221",
<   {
<     "maxReplicas": "3",
<     "minReplicas": "2",
<     "targetCPUUtilizationPercentage": "80"
<   }
< ]
< [
<   "horizontal-pod-autoscaler",
<   "modules.my-sample-workload.externals.test2",
<   "default",
<   "humanitec/template",
<   "hpa-explicit",
<   "495e24e2-4e97-4994-a02f-a0a905801221",
<   {
<     "maxReplicas": "3",
<     "minReplicas": "2",
<     "targetCPUUtilizationPercentage": "80"

@mathieu-benoit mathieu-benoit merged commit cdf2829 into main Dec 30, 2024
2 checks passed
@mathieu-benoit mathieu-benoit deleted the arm64-support branch December 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant