Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monotonous and derivative #1448

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

This PR contains a proof that "decreasing implies non-positive derivative".
@t6s If I remember correctly, you proved similar lemmas somewhere.
Are they in some pending PRs or do you have them elsewhere?
(By the way, the lemmas in this PR are used to prove integration-by-substitution like lemmas.)

@IshiguroYoshihiro you may want to amend this PR.

Checklist
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers

Reference: How to document

Reminder to reviewers

@affeldt-aist affeldt-aist added this to the 1.9.0 milestone Jan 7, 2025
@t6s
Copy link
Member

t6s commented Jan 7, 2025

Yes, I have a local branch for a similar PR, though not ready yet.

I'm happy to have this PR going first, so that I can generalize the lemmas as needed.

@affeldt-aist affeldt-aist mentioned this pull request Jan 8, 2025
2 tasks
@affeldt-aist
Copy link
Member Author

affeldt-aist commented Jan 8, 2025

Ah, I remember now. We were actually discussing generalizations of the lemmas that establish monotonicity from the sign of the derivative, as the two lemmas in this commit 2b63e89
(the lemmas in the previous commit are doing the contrary).
I think that you had other variants of the lemmas in the second commit.

Ideally, we want to factorize all of the them as a few generic lemmas exploiting the Interval type.

@affeldt-aist affeldt-aist requested a review from t6s January 8, 2025 06:31
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Jan 8, 2025
@affeldt-aist affeldt-aist requested review from t6s and removed request for t6s January 14, 2025 01:04
@affeldt-aist
Copy link
Member Author

@t6s : @IshiguroYoshihiro has added variants so that this PR might actually cover what you were working on afaiu

Copy link
Member

@t6s t6s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you quickly add closureT and closure0?

Future TODOs:

  • generalize interior_set1 (to metric spaces (=pseudometric + hausdorff)?)
  • split normedtype.v into generic and real-specific files
  • add closure_itv_{bnd, bndy, Nybnd, Nyy}

theories/topology_theory/topology_structure.v Outdated Show resolved Hide resolved
@t6s
Copy link
Member

t6s commented Jan 20, 2025

affeldt-aist#24
added closureT

@affeldt-aist affeldt-aist force-pushed the derive_20250107 branch 2 times, most recently from 7e609e4 to 2fddf4c Compare February 4, 2025 13:56
@affeldt-aist
Copy link
Member Author

I'll merge when the CI is green, since these lemmas are much needed in other PRs and in infotheo.

@affeldt-aist affeldt-aist merged commit 1191572 into math-comp:master Feb 4, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants