Adapt to MC#1319 #106
Closed
Adapt to MC#1319 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Tragicus
force-pushed
the
mc1319
branch
3 times, most recently
from
7c4be5b to
3d7ed71
Compare
pi8027
reviewed
Jan 20, 2025
Comment on lines
+181
to
+186
| pred sring->pzsring i:term, o:term. | ||
| sring->pzsring U V :- | ||
| if (coq.locate-all "pzSemiRingType" [loc-gref PzSemiRingType| _ ]) | ||
| (coq.elaborate-skeleton U (global PzSemiRingType) V ok) | ||
| (V = U). | ||
|
|
There was a problem hiding this comment.
Calling this predicate every time we process a ring operator looks a bit costly. Isn't it possible to define compatibility notations (or constants) for GRing.SemiRing.sort, GRing.ComSemiRing.sort, GRing.Ring.sort, and GRing.ComRing.sort and replace their occurrences in common.elpi?
There was a problem hiding this comment.
Yes, Cyril raised the same issue. He figured that we could make the code more robust to the changes that are happening in mathcomp by precomputing the coercions that coq.elaborate-skeleton would insert, see #108).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
math-comp/math-comp#1319 generalizes
1topzSemiRingType, which means that we need to generalize things here too.