Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt to MC#1256 #100

Closed
wants to merge 1 commit into from
Closed

adapt to MC#1256 #100

wants to merge 1 commit into from

Conversation

Tragicus
Copy link
Contributor

math-comp/math-comp#1256 generalizes operations. This PR generalizes everything that was on nmodType to baseAddUMagmaType (and addition to addMagmaType). It also changes the mem predicate in common.elpi to use coq.unify-eq because elpi's unification is not module delta, which causes issues when N-modules are cast to baseAddUMagmaType.

@Tragicus Tragicus mentioned this pull request Aug 21, 2024
Merged
pi8027
pi8027 requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@pi8027 pi8027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, baseAddMagmaType and baseAddUMagmaType instances should rather be stored in the additive and rmorphism datatypes for performance reasons. I'm fine with dropping the support for released versions of MathComp.

@Tragicus Tragicus mentioned this pull request Jan 20, 2025
Merged
@Tragicus Tragicus closed this Jan 21, 2025
@Tragicus Tragicus deleted the pr1256 branch January 22, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi8027 pi8027 pi8027 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tragicus @pi8027