Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Split VASP input sets into submodules" #3989

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Revert "Split VASP input sets into submodules" #3989

merged 1 commit into from
Aug 9, 2024

Conversation

shyuep
Copy link
Member

@shyuep shyuep commented Aug 9, 2024

Reverts #3865.

  1. I did not agree to this.
  2. It clearly broke something. See Breaking behavior: Removal of pymatgen.io.vasp.sets.get_vasprun_outcar without warning #3988

@shyuep shyuep requested review from janosh and mkhorton as code owners August 9, 2024 16:31
@shyuep shyuep merged commit f1eb364 into master Aug 9, 2024
2 of 6 checks passed
@shyuep shyuep deleted the revert-3865-split-vasp-sets branch August 9, 2024 16:31
@hongyi-zhao hongyi-zhao mentioned this pull request Aug 9, 2024
Merged
@janosh janosh mentioned this pull request Aug 11, 2024
Closed
mkhorton pushed a commit that referenced this pull request Aug 12, 2024
Reapply "Split VASP input sets into submodules (#3865)" (#3989)
1c9684e 
This reverts commit f1eb364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh Awaiting requested review from janosh

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shyuep