Skip to content

Commit

Permalink
Fix positional arguments.
Browse files Browse the repository at this point in the history
  • Loading branch information
shyuep committed Jun 26, 2024
1 parent 4127d82 commit f10ace8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pymatgen/analysis/solar/slme.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def slme(
solar_spectra_photon_flux = solar_spectra_irradiance * (solar_spectra_wavelength_meters / (h * c))

# Calculation of total solar power incoming
power_in = simpson(solar_spectra_irradiance, solar_spectra_wavelength)
power_in = simpson(solar_spectra_irradiance, x=solar_spectra_wavelength)

# calculation of blackbody irradiance spectra
# units of W/(m**3), different than solar_spectra_irradiance!!! (This
Expand Down Expand Up @@ -238,13 +238,13 @@ def slme(
* np.pi
* simpson(
blackbody_photon_flux * absorbed_by_wavelength,
solar_spectra_wavelength_meters,
x=solar_spectra_wavelength_meters,
)
)

J_0 = J_0_r / fr

J_sc = e * simpson(solar_spectra_photon_flux * absorbed_by_wavelength, solar_spectra_wavelength)
J_sc = e * simpson(solar_spectra_photon_flux * absorbed_by_wavelength, x=solar_spectra_wavelength)

def J(V):
return J_sc - J_0 * (np.exp(e * V / (k * temperature)) - 1.0)
Expand Down

0 comments on commit f10ace8

Please sign in to comment.