Re-added functionality back to lpad.get_fw_id_from_reservation_id(reservation_id) #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged name from get_fw_ids_from_reservation_id to just get_fw_id_from_reservation_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Major changes:
two revamped functionalities of launchpad
lpad.get_fw_id_from_reservation_id is now working (previously did not work due to the lack of a reservation_id tag)
lpad.get_reservation_id_from_fw_id is now working (previously did not work due to the lack of a reservation_id tag)
They currently only work on slurm. This addition to fireworks used code chunks from Sustodian (https://github.com/wuz75/sustodian.git)
detailed changes
Added a file called fw_id_from_reservation_id.py and another called reservation_id_from_fw_id.py in fireworks.utilities which does the bulk of the parsing. reservation_finder.py uses the scontrol show jobid command to parse launch directories and find the FW.json file of the running job. When running lpad.get_fw_id_from_reservation_id(slurm job id) locally, it will prompt a username@hostname and password+OTP via paramiko ssh. Otherwise it will just run the functions in reservation_finder.py lpad.get_reservation_id_from_fw_id(fw_id) works very similarly and parses through all running jobs to match jobids with fwids.