Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error color parameter in URL is not effective #355

Open
wangweixuan opened this issue Nov 9, 2024 · 0 comments
Open

Error color parameter in URL is not effective #355

wangweixuan opened this issue Nov 9, 2024 · 0 comments

Comments

@wangweixuan
Copy link

wangweixuan commented Nov 9, 2024

Describe the bug
The error parameter in URL, e.g. https://material-foundation.github.io/material-theme-builder/?error=%2300ff00, is not effective like primary or secondary parameters.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://material-foundation.github.io/material-theme-builder/?primary=%2300ff00
  2. See that the primary color is #00ff00, as is specified in the URL.
  3. Go to https://material-foundation.github.io/material-theme-builder/?error=%2300ff00
  4. See that the error color remains the default color.

The "Copy link" button on the export page generates links like http://material-foundation.github.io?primary=%23B33B15&error=%2300FF00&colorMatch=false, which suggests that the error parameter should work. (The link itself does not work due to #338.)

Expected behavior
The chosen error color should be recovered after opening the link.

@wangweixuan wangweixuan changed the title Broken share links Error color parameter in URL is not effective Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant