This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Formatter and linter for more file types #522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in [1], when prettier formats at least one file, it always prints the paths of all changed files, regardless whether it changed them. They come in different shades of grey, but in a light theme they are almost undistinguishable. Therefore, we have to decide if we want to see the paths of all files, or none and just a hint of pre-commit that files were changed by this hook. I will keep it this way for now, as `git diff` will also list the changes. [1]: prettier/prettier#3525
|
@bjrne How should we handle this atm? Should we
What state is this in? |
|
Since curlylint is in Heavy Development i will Test it again and decide then. I will then take appropriate action. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namely:
-js
-markdown
-yaml
All from the
prettierformatter.HTML support for django tags is really hard apparently, so this might only include indentation for html, and even that only if we're lucky.