fix: incorrect log line, single source of truth for version number (pyproject.toml) #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR description is too short and seems to not fulfill PR template, please fill in |
1 similar comment
|
PR description is too short and seems to not fulfill PR template, please fill in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
+ Coverage 32.13% 32.17% +0.04%
==========================================
Files 23 23
Lines 1640 1641 +1
==========================================
+ Hits 527 528 +1
Misses 1113 1113 ☔ View full report in Codecov by Sentry. |
|
PR description is too short and seems to not fulfill PR template, please fill in |
hide-on-bush-x
previously approved these changes
Feb 27, 2025
…to hardcode in 2 different files.
|
PR description is too short and seems to not fulfill PR template, please fill in |
5u6r054
changed the title
hide-on-bush-x
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version Bump to 1.5.4, version reference to one single source of truth, and fix Version Logging
Description
v1.5.3 had a small issue with logging the version incorrectly, but also had a larger issue with the version reference not being a single source of truth.
previously, to release a new version, one would need to update the version in the pyproject.yaml file, the init.py file, and the release notes.
Now, to release a new version, one only needs to update the version in the pyproject.yaml file.
This version bumps up to 1.5.4, and will correctly log the current and required versions at init.
or, if not up to date:
🟡 Code is outdated! Current: 153, Required: 154. Please update your code to the latest release!
Changes
Notes for Reviewers
This is a critical update that must be released before updating subnet hyperparameters.