Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let print_to_stream also print the end of a source region #244

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

N-Dekker
Copy link
Contributor

With this commit, std::cout << node.source() should print both the begin and the end of the source region.

  • I've read CONTRIBUTING.md
  • I've rebased my changes against the current HEAD of origin/master (if necessary)
  • I've added new test cases to verify my change
  • I've regenerated toml.hpp (how-to)
  • I've updated any affected documentation
  • I've rebuilt and run the tests with at least one of:
    • Clang 8 or higher
    • GCC 8 or higher
    • MSVC 19.20 (Visual Studio 2019) or higher
  • I've added my name to the list of contributors in README.md

With this commit, `std::cout << node.source()` should print both the begin and the end of the source region.
@N-Dekker N-Dekker marked this pull request as ready for review January 31, 2025 09:02
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Feb 7, 2025

@marzer Thank you for the suggestion! Shall I squash you suggested commit on my fork? Otherwise you may also do a squash-and-merge on GitHub when you think this PR is good enough, of course.

@marzer
Copy link
Owner

marzer commented Feb 7, 2025

All good, we can squash-and-merge when it is brought into main. Just need to update the single-header version and I'll merge it in 👍🏼

Co-authored-by: Mark Gillard <marzer_@hotmail.com>
@N-Dekker N-Dekker force-pushed the print_to_stream-end-of-source-region branch from 5b37585 to 40b5d61 Compare February 7, 2025 08:36
@marzer marzer merged commit 1fdd67c into marzer:master Feb 7, 2025
3 of 8 checks passed
@marzer
Copy link
Owner

marzer commented Feb 7, 2025

Thanks 🎉

N-Dekker added a commit to N-Dekker/tomlplusplus that referenced this pull request Feb 8, 2025
Tested commit 1fdd67c, "let `print_to_stream` also print the end of a source region (marzer#244)"
marzer pushed a commit that referenced this pull request Feb 10, 2025
Tested commit 1fdd67c, "let `print_to_stream` also print the end of a source region (#244)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants