Several changes #154
Merged
Several changes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not update player ratings for games that ended due to a disconnect. Those games are incomplete, so they should not go into the rating.
This method is intended to be called from outside, so should not be marked as private.
The limit can be configured via the setting `max_parallel_games`. Matchmaking simply returns early if the limit is reached. Note that this results in missing or incomplete match quality scores when the limit is reached but I prefer this over a more complicated implementation (those scores are anyway only relevant when games can be started).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
The limit is currently set to 100, so pretty high, but it will allow us to easily reduce it if we notice performance issues on the server.