Add ContentLength handler for checking the Content-Length HTTP header… #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Update to the newest api of the gomega dependency.
| @@ -48,6 +48,16 @@ func ContentType(ctypes ...string) http.HandlerFunc { | |||
| } | |||
| } | |||
|
|
|||
| // ContentLength generates a handler that writes a 411 Length Required response if the request | |||
| // doesn't contain the Content-Length header | |||
There was a problem hiding this comment.
Can you please add a trailing ".", to be consistent with other comments in the file?
|
Thank you very much, this seems like a great addition. I'll merge this on Monday, sorry for having to wait so long! |
|
Hi, |
|
OK, please ping me when you do the update. Just remember please to follow the RFC in case you get an error from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update to the newest api of the gomega dependency