Added a clear method that deletes all the values in a session #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,6 +119,12 @@ func (s *session) Delete(key interface{}) { | |||
| s.written = true | |||
| } | |||
|
|
|||
| func (s *session) Clear() { | |||
| for key := range s.Session().Values { | |||
| s.Delete(key) | |||
There was a problem hiding this comment.
I contemplated repeating the code from the Delete method and then setting s.written = true only once. The current implementation has the advantage of code reuse and that s.written is only updated if Values is non-empty.
There was a problem hiding this comment.
I like this approach for now. I doubt we will be bottlenecking on iteration time here :)
|
Very cool. I will take a look at this soon |
|
Nice work! Thanks for putting this together |
codegangsta
added a commit
that referenced
this pull request
Mar 12, 2014
Added a clear method that deletes all the values in a session
|
Nice! Perhaps add it in the example in the readme and close this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the functionality discussed in issue #3.