Skip to content

Commit

Permalink
fixed a bug in get_question_hour where the $question_time$answer_by_i…
Browse files Browse the repository at this point in the history 
…d returned character() at times, making the vector shorter than the other vectors in the data frame
  • Loading branch information
@martigso
martigso committed Oct 23, 2024
1 parent aa5796d commit c88f5e9
Showing 1 changed file with 36 additions and 32 deletions.
68 changes: 36 additions & 32 deletions R/get_question_hour.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,38 +130,42 @@ get_question_hour <- function(meetingid = NA, good_manners = 0){
question_hour_ministers = data.frame(
id = tmp |> html_elements("muntlig_sporretime > statsraader > person > id") |> html_text()
),
question_time = data.frame(
question_justification = tmp |> html_elements("ordinaer_sporretime_sporsmal_liste > detaljert_sporsmal > begrunnelse") |> html_text(),
answer_by_id = tmp |> html_elements("detaljert_sporsmal > besvart_av > id") |> html_text(),
answer_by_minister_id = tmp |> html_elements("detaljert_sporsmal > besvart_av_minister_id") |> html_text(),
answer_by_minister_title = tmp |> html_elements("detaljert_sporsmal > besvart_av_minister_tittel") |> html_text(),
answer_date = tmp |> html_elements("detaljert_sporsmal > besvart_dato") |> html_text(),
answer_on_behalf_of_id = sapply(tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av"),
function(x) x |> html_elements("id") |> html_text() |> paste0("_h")),
answer_on_behalf_of_minister_id = tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av_minister_id") |> html_text(),
answer_on_behalf_of_minister_title = tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av_minister_tittel") |> html_text(),
agenda_case_number = tmp |> html_elements("detaljert_sporsmal > dagsorden_saknummer") |> html_text(),
date = tmp |> html_elements("detaljert_sporsmal > datert_dato") |> html_text(),
moved_to = tmp |> html_elements("detaljert_sporsmal > flyttet_til") |> html_text(),
asked_by_other_id = sapply(tmp |> html_elements("detaljert_sporsmal > fremsatt_av_annen"),
function(x) x |> html_elements("id") |> html_text() |> paste0("_h")),
question_id = tmp |> html_elements("detaljert_sporsmal > id") |> html_text(),
correct_person = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende") |> html_text(),
correct_person_minister_id = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende_minister_id") |> html_text(),
correct_person_minister_title = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende_minister_tittel") |> html_text(),
sent_date = tmp |> html_elements("detaljert_sporsmal > sendt_dato") |> html_text(),
session_id = tmp |> html_elements("detaljert_sporsmal > sesjon_id") |> html_text(),
question_text = tmp |> html_elements("detaljert_sporsmal > sporsmal") |> html_text(),
question_from_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_fra > id") |> html_text(),
question_number = tmp |> html_elements("detaljert_sporsmal > sporsmal_nummer") |> html_text(),
question_to_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_til > id") |> html_text(),
question_to_minister_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_til_minister_id") |> html_text(),
question_to_minister_title = tmp |> html_elements("detaljert_sporsmal > sporsmal_til_minister_tittel") |> html_text(),
status = tmp |> html_elements("detaljert_sporsmal > status") |> html_text(),
answer = tmp |> html_elements("detaljert_sporsmal > svar") |> html_text(),
title = tmp |> html_elements("detaljert_sporsmal > tittel") |> html_text(),
type = tmp |> html_elements("detaljert_sporsmal > type") |> html_text()
),
question_time =
data.frame(
question_justification = tmp |> html_elements("ordinaer_sporretime_sporsmal_liste > detaljert_sporsmal > begrunnelse") |> html_text(),
answer_by_id = sapply(tmp |> html_elements("detaljert_sporsmal > besvart_av"),
function(x) ifelse(identical(x |> html_elements("id") |> html_text(), character()),
NA,
x |> html_elements("id") |> html_text())),
answer_by_minister_id = tmp |> html_elements("detaljert_sporsmal > besvart_av_minister_id") |> html_text(),
answer_by_minister_title = tmp |> html_elements("detaljert_sporsmal > besvart_av_minister_tittel") |> html_text(),
answer_date = tmp |> html_elements("detaljert_sporsmal > besvart_dato") |> html_text(),
answer_on_behalf_of_id = sapply(tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av"),
function(x) x |> html_elements("id") |> html_text() |> paste0("_h")),
answer_on_behalf_of_minister_id = tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av_minister_id") |> html_text(),
answer_on_behalf_of_minister_title = tmp |> html_elements("detaljert_sporsmal > besvart_pa_vegne_av_minister_tittel") |> html_text(),
agenda_case_number = tmp |> html_elements("detaljert_sporsmal > dagsorden_saknummer") |> html_text(),
date = tmp |> html_elements("detaljert_sporsmal > datert_dato") |> html_text(),
moved_to = tmp |> html_elements("detaljert_sporsmal > flyttet_til") |> html_text(),
asked_by_other_id = sapply(tmp |> html_elements("detaljert_sporsmal > fremsatt_av_annen"),
function(x) x |> html_elements("id") |> html_text() |> paste0("_h")),
question_id = tmp |> html_elements("detaljert_sporsmal > id") |> html_text(),
correct_person = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende") |> html_text(),
correct_person_minister_id = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende_minister_id") |> html_text(),
correct_person_minister_title = tmp |> html_elements("detaljert_sporsmal > rette_vedkommende_minister_tittel") |> html_text(),
sent_date = tmp |> html_elements("detaljert_sporsmal > sendt_dato") |> html_text(),
session_id = tmp |> html_elements("detaljert_sporsmal > sesjon_id") |> html_text(),
question_text = tmp |> html_elements("detaljert_sporsmal > sporsmal") |> html_text(),
question_from_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_fra > id") |> html_text(),
question_number = tmp |> html_elements("detaljert_sporsmal > sporsmal_nummer") |> html_text(),
question_to_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_til > id") |> html_text(),
question_to_minister_id = tmp |> html_elements("detaljert_sporsmal > sporsmal_til_minister_id") |> html_text(),
question_to_minister_title = tmp |> html_elements("detaljert_sporsmal > sporsmal_til_minister_tittel") |> html_text(),
status = tmp |> html_elements("detaljert_sporsmal > status") |> html_text(),
answer = tmp |> html_elements("detaljert_sporsmal > svar") |> html_text(),
title = tmp |> html_elements("detaljert_sporsmal > tittel") |> html_text(),
type = tmp |> html_elements("detaljert_sporsmal > type") |> html_text()
),
publication_reference = data.frame(
export_id = tmp |> html_elements("publikasjon_referanse > eksport_id") |> html_text(),
link_text = tmp |> html_elements("publikasjon_referanse > lenke_tekst") |> html_text(),
Expand Down

0 comments on commit c88f5e9

Please sign in to comment.