fixed an error in get_proposal_votes() on the proposal_delivered_by_m…

…p variable
martigso · Oct 16, 2024 · 1035d18 · 1035d18
1 parent bb433f3
commit 1035d18
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -18,6 +18,6 @@ Imports: rvest, httr2, parallel, stringr
 Suggests: imager, rmarkdown, knitr, pscl
 License: GPL (>= 3)
 VignetteBuilder: knitr
-RoxygenNote: 7.3.1
+RoxygenNote: 7.3.2
 Roxygen: list(markdown = TRUE)
 LazyData: true
diff --git a/NEWS.md b/NEWS.md
@@ -1,7 +1,15 @@
 # stortingscrape 0.3.1
 
+- Minor changes
+    * Fixed call to sleep in `get_publication()` function (was missing)
+    * Redirected citation to inst/CITATION file
+    * Fixed a minor error in the `get_proposal_votes()` function for the `proposal_delivered_by_mp` variable
+
 # stortingscrape 0.3.0
 
+- Minor changes
+    * Fixed an error in `get_session_cases()`, where the structuring of case proposers did not run in parallel, as was intended.
+
 # stortingscrape 0.2.0
 
 - Major changes:

diff --git a/R/get_proposal_votes.R b/R/get_proposal_votes.R
@@ -108,7 +108,7 @@ get_proposal_votes <- function(voteid = NA, good_manners = 0){
                                  proposal_designation = tmp |> html_elements("voteringsforslag > forslag_betegnelse") |> html_text(),
                                  proposal_designation_short = tmp |> html_elements("voteringsforslag > forslag_betegnelse_kort") |> html_text(),
                                  proposal_id = tmp |> html_elements("voteringsforslag > forslag_id") |> html_text(),
-                                 proposal_delivered_by_mp = tmp |> html_elements("voteringsforslag > forslag_levert_av_representant") |> html_text(),
+                                 proposal_delivered_by_mp = tmp |> html_elements("voteringsforslag > forslag_levert_av_representant > id") |> html_text(),
                                  proposal_on_behalf_of_text = tmp |> html_elements("voteringsforslag > forslag_paa_vegne_av_tekst") |> html_text(),
                                  proposal_sortingnumber = tmp |> html_elements("voteringsforslag > forslag_sorteringsnummer") |> html_text(),
                                  proposal_text = tmp |> html_elements("voteringsforslag > forslag_tekst") |> html_text(),