Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty value #39

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Empty value #39

merged 1 commit into from
Oct 30, 2024

Conversation

KozyrevIvan
Copy link
Contributor

I think empty_value would be better to use an empty string rather than None since I expect the field to behave like a CharField and in it empty_value = ""

marksweb
marksweb approved these changes Oct 30, 2024
View reviewed changes
Copy link
Owner

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think that's a fair catch on something that's been overlooked so far.

Thanks.

@marksweb marksweb merged commit b1718de into marksweb:main Oct 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KozyrevIvan @marksweb