chore: upgrade checkout to v4 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcalthrop
reviewed
Dec 9, 2024
.github/workflows/pr.yml
Outdated
| @@ -15,7 +15,7 @@ jobs: | |||
| name: Secret scan | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@4.2.2 | |||
There was a problem hiding this comment.
Need to provide v:
Suggested change
| - uses: actions/checkout@4.2.2 | |
| - uses: actions/checkout@v4.2.2 |
And same for others.
There was a problem hiding this comment.
Do you get an error flagged in VSCode, like this?
mcalthrop
reviewed
Dec 9, 2024
.github/workflows/pr.yml
Outdated
| @@ -98,7 +98,7 @@ jobs: | |||
| if: ${{ always() }} | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: actions/checkout@4.2.2 | |||
|
|
|||
| - name: Check jobs for errors | |||
| uses: actions/github-script@v6 | |||
There was a problem hiding this comment.
Might as well fix this while we're here:
Suggested change
| uses: actions/github-script@v6 | |
| uses: actions/github-script@v6.4.1 |
mcalthrop
reviewed
Dec 9, 2024
Co-authored-by: Matt Calthrop <matt@calthrop.com>
mcalthrop
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
checkout is on v3
Solution
upgrade to v4
Useful documentation