Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAGS API] fix serializing attr tag iterators. #2522

Merged
merged 1 commit into from
Feb 15, 2025
Merged

[TAGS API] fix serializing attr tag iterators. #2522

merged 1 commit into from
Feb 15, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 15, 2025

🦋 Changeset detected

Latest commit: 9b026d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 78.43137% with 11 lines in your changes missing coverage. Please review.

Project coverage is 87.06%. Comparing base (bc3189e) to head (3f5a414).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/html/serializer.ts 79.54% 9 Missing ⚠️
packages/runtime-tags/src/common/helpers.ts 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2522      +/-   ##
==========================================
- Coverage   87.09%   87.06%   -0.03%     
==========================================
  Files         352      352              
  Lines       40431    40447      +16     
  Branches     2679     2683       +4     
==========================================
+ Hits        35212    35217       +5     
- Misses       5193     5204      +11     
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit 2687edc into main Feb 15, 2025
8 of 10 checks passed
@DylanPiercey DylanPiercey deleted the wip branch February 15, 2025 23:44
@github-actions github-actions bot mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant