Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore native tag state before change handlers are called #2520

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: f99c90f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey DylanPiercey changed the title fix: restore native tage state before change handlers are called fix: restore native tag state before change handlers are called Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 83.72093% with 7 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (f912994) to head (f99c90f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/controllable.ts 83.72% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
+ Coverage   87.02%   87.09%   +0.06%     
==========================================
  Files         352      352              
  Lines       40465    40431      -34     
  Branches     2678     2679       +1     
==========================================
- Hits        35216    35212       -4     
+ Misses       5222     5193      -29     
+ Partials       27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit bc3189e into main Feb 14, 2025
9 of 10 checks passed
@DylanPiercey DylanPiercey deleted the wip branch February 14, 2025 16:24
@github-actions github-actions bot mentioned this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant