Final Polaris changes #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polaris changes Polaris changes
rjrudin
approved these changes
May 1, 2025
| @@ -203,8 +205,9 @@ protected PropertyDescriptor getSupportedDynamicPropertyDescriptor(final String | |||
|
|
|||
| protected ServerTransform buildServerTransform(ProcessContext context) { | |||
| ServerTransform serverTransform = null; | |||
| Objects.requireNonNull(context.getProperty(TRANSFORM), "TRANSFORM property should not be null"); | |||
| final String transform = context.getProperty(TRANSFORM).getValue(); | |||
| PropertyValue transformProperty = context.getProperty(TRANSFORM); | |||
There was a problem hiding this comment.
Not needed now, but this pattern is repeated so often that it'd be worth making helper methods in the parent class to provide syntactic sugar so you can just do e.g.:
String value = getPropertyValue(context, TRANSFORM);
And then parent method would do the null check. Can add variants that evaluate based on the context or the FlowFile too. Just gets it all back down to one line of code per property value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final Polaris changes