Brand version into source code

mariusklocke · Dec 11, 2023 · f5cffdf · f5cffdf
1 parent a874c3b
commit f5cffdf
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/docker/php/Dockerfile b/docker/php/Dockerfile
@@ -41,7 +41,6 @@ WORKDIR ${APP_HOME}
 # Install dependencies first
 COPY composer.lock composer.json ./
 RUN composer install --optimize-autoloader --no-cache --no-dev --no-progress
-RUN echo "$APP_VERSION" > VERSION
 
 # Install own application sources
 COPY templates templates/
@@ -51,6 +50,9 @@ COPY migrations migrations/
 COPY config config/
 COPY bin bin/
 
+# Apply version branding
+RUN sed -i "s/APP_VERSION=development/APP_VERSION=$APP_VERSION/" src/init.php
+
 # Configure ownership and permissions
 RUN chown -R www-data:www-data ${APP_HOME} && chmod +x bin/*
 USER www-data

diff --git a/src/Infrastructure/CLI/Application.php b/src/Infrastructure/CLI/Application.php
@@ -58,7 +58,7 @@ public function __construct()
 
         parent::__construct(
             'Liga-Manager',
-            $this->container->get('version')
+            getenv('APP_VERSION') ?: 'development'
         );
 
         foreach ($this->getOwnCommands() as $command) {

diff --git a/src/Infrastructure/ContainerBuilder.php b/src/Infrastructure/ContainerBuilder.php
@@ -14,11 +14,8 @@ class ContainerBuilder
      */
     public static function build(array $serviceProviders): ContainerInterface
     {
-        $versionFilePath = join(DIRECTORY_SEPARATOR, [getenv('APP_HOME'), 'VERSION']);
-
         $builder = new DI\ContainerBuilder();
         $builder->useAutowiring(true);
-        $builder->addDefinitions(['version' => @file_get_contents($versionFilePath) ?: 'development']);
 
         foreach ($serviceProviders as $provider) {
             $builder->addDefinitions($provider->getDefinitions());

diff --git a/src/init.php b/src/init.php
@@ -4,6 +4,7 @@
 require_once __DIR__ . '/../vendor/autoload.php';
 
 putenv("APP_HOME=" . realpath(join(DIRECTORY_SEPARATOR, [__DIR__ , '..'])));
+putenv("APP_VERSION=development");
 
 switch (php_sapi_name()) {
     case 'fpm-fcgi':