Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyro controls not working anymore on 1.6.4 #358

Closed
Mothamoz opened this issue Jan 15, 2024 · 11 comments · Fixed by #360
Closed

Gyro controls not working anymore on 1.6.4 #358

Mothamoz opened this issue Jan 15, 2024 · 11 comments · Fixed by #360
Labels
bug Something isn't working can't reproduce Issues that are hard to solve input Issue about keyboard/mouse/gamepad

Comments

@Mothamoz
Copy link

Mothamoz commented Jan 15, 2024

Moonlight Version

1.6.4

Device Type

webOS TV

Device Model

LG CX

Device OS

webOS 5.5.0

Host OS

Windows

Host Software

Sunshine

Host Setup

i7-13700k, NVIDIA RTX 4070Ti, 32GB DDR4-4400

Bug Description

After the latest moonlight update my DS4 controllers do not pass through gyro anymore. I tested this by opening Yuzu through my client's moonlight and configuring controls, the gyro isn't picked up at all.
The controller however is recognized correctly as a DualShock 4.

I've also closed down the stream and restarted it multiple times to no avail.

Reproduction Steps

Start a stream using a DS4 or (probably) any other gyro supported controller and you'll see the gyro does not work.

Expected Behavior

Gyro controls to be passed through and working correctly.

@Mothamoz Mothamoz added the bug Something isn't working label Jan 15, 2024
@mariotaku
Copy link
Owner

I have tested v1.6.4 with Aimlabs and other apps, and gyro works. How did you connect the gamepad?

@mariotaku mariotaku added can't reproduce Issues that are hard to solve input Issue about keyboard/mouse/gamepad labels Jan 16, 2024
@Mothamoz
Copy link
Author

They are connected through bluetooth, directly to the TV. I will do some more troubleshooting and testing later today and report back

@mariotaku
Copy link
Owner

Actually, I didn't expect the PS4 controller to have a working gyro via Bluetooth at all. What about USB connection?

@Mothamoz
Copy link
Author

Actually, I didn't expect the PS4 controller to have a working gyro via Bluetooth at all. What about USB connection?

It worked perfectly ever since you implemented gyro support :) Besides it being apparently broken for me now

I'll try a USB connection but I'd rather not have that be a permanent solution due to distance from the TV & couch, and bluetooth working fine before

@mariotaku
Copy link
Owner

I know USB connection is less than ideal, but because bluetooth support on webOS is so inconsistent, I'd suggest using a dongle instead. On my TV, it's not possible to test such feature at all, so I'm not able to fix if webOS breaks it.

@Mothamoz
Copy link
Author

I tried a magicflash ultimate but the controller limit to 2 plus the usage was annoying, i'll do some troubleshooting this evening and report back. Hopefully we can find out what changed between 1.6.4 and 1.6.2 that makes it not work

@mariotaku
Copy link
Owner

You're right! I realized there's a possible change that leads to this issue: webosbrew/SDL-webOS@4146c8a

I'll make some changes to see.

@Mothamoz
Copy link
Author

Nice! Let me know when or if I should test a build or something else!

@mariotaku
Copy link
Owner

https://github.com/mariotaku/moonlight-tv/actions/runs/7551192089
Does this work for you? Switch Pro Controller can't work via Bluetooth without that patch, so I made it only for Nintendo devices.
Do you have a Switch controller to test out?

@Mothamoz
Copy link
Author

https://github.com/mariotaku/moonlight-tv/actions/runs/7551192089
Does this work for you? Switch Pro Controller can't work via Bluetooth without that patch, so I made it only for Nintendo devices.
Do you have a Switch controller to test out?

Unfortunately I don't, only have ds4's laying around

@mariotaku
Copy link
Owner

@Mothamoz I bought a DualShock 4 controller and tested. Looks like the fix works well. I'll make another release with some other fixes.

@mariotaku mariotaku linked a pull request Jan 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce Issues that are hard to solve input Issue about keyboard/mouse/gamepad
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants