Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🗃️ create table conditions #40

Merged
merged 5 commits into from
Jan 22, 2024
Merged

🗃️ create table conditions #40

merged 5 commits into from
Jan 22, 2024

Conversation

quentin-burg
Copy link
Collaborator

@quentin-burg quentin-burg commented Jan 11, 2024 •
edited
Loading

Business rules :

  • condition type must be MAX_CALLS_PER_ENTRYPOINT or MAX_CALLS_PER_ENTRYPOINT
  • condition can be created with required parameters
  • condition cannot be created if there exists a condition with same parameters and maximum not reached

@quentin-burg quentin-burg requested a review from aguillon January 11, 2024 17:35
@quentin-burg
Copy link
Collaborator Author

@aguillon Still draft because need to test with frontend (maybe some informations are needed with frontend interface)

@quentin-burg quentin-burg marked this pull request as ready for review January 12, 2024 18:01
aguillon
aguillon approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@aguillon aguillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a few minor things. I have some concerns about how things are going to be rewritten if we allow a same contract to be sponsored by several vaults, each with different conditions.

src/models.py Show resolved Hide resolved
src/utils.py Outdated Show resolved Hide resolved
src/crud.py Outdated Show resolved Hide resolved
src/routes.py Outdated Show resolved Hide resolved
src/crud.py Outdated Show resolved Hide resolved
@quentin-burg quentin-burg mentioned this pull request Jan 18, 2024
Open
aguillon
aguillon approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@aguillon aguillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's test on staging.

src/crud.py Show resolved Hide resolved
@quentin-burg quentin-burg merged commit 5424a48 into staging Jan 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguillon aguillon aguillon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quentin-burg @aguillon