Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages with links appear out of order #68

Open
iangreenleaf opened this issue Apr 9, 2013 · 2 comments
Open

Messages with links appear out of order #68

iangreenleaf opened this issue Apr 9, 2013 · 2 comments

Comments

@iangreenleaf
Copy link

When I join a room, messages that begin with a URL appear last in the sent messages, out of order. I think I know why. Inline links trigger this predicate:

def needsThread(self):
    return self._message.is_upload() or (self._message.body and self._isInlineLink(self._message.body))

It looks like these messages get rendered in a thread, which is probably why they don't end up in he right order.

Possibly #59 has the same cause.

@basilgohar
Copy link

I've observed this behaviour as well. I was wondering why that would happen, and working in a thread would explain it.

@goblin
Copy link

goblin commented Jun 5, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants