Skip to content

Removing GestureDetector component

Latest
Compare
Choose a tag to compare
@marcuzgabriel marcuzgabriel released this 31 Jul 10:42
· 4 commits to master since this release
3a2dc6d

Unfortunately a bug has been observed where the screen freezes when pressing / entering and returning to the overview. This bug is only on iOS.

I have tried everything to debug it. The conclusion is related software-mansion/react-native-reanimated#3331. The new gesture component GestureDetector do not handle on mount very well.

I had three possible solutions:

Reintroduce old working gesture handling solution
Combine old and new RNGH solution and add a prop useLatestRNGH to determine which one to use
Debug and figure out what is the problem
I started with solution 3, which is currently in place (previous version). I removed the defined 'worklet' approach which causes a bad warning as RNGH gets confused on what thread to use. But it worked. The debugging is pure guessing as there is no proper debugging information for worklets when working with the UI thread.

I tried to do solution 2 but it introduces ALOT of extra code and make readability and complexity ALOT more difficult.

*** The only viable solution is 1: remove latest RNGH2.0 and go back to reanimated useAnimatedGestureHandler and wait for RNGH to fix their GestureDetector ***

What's Changed

New Contributors

Full Changelog: https://github.com/marcuzgabriel/reanimated-bottom-sheet/commits/v.1.0.3