Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing IP from previous scan #17

Open
Shotokanman opened this issue Sep 4, 2020 · 6 comments · May be fixed by #18
Open

removing IP from previous scan #17

Shotokanman opened this issue Sep 4, 2020 · 6 comments · May be fixed by #18
Labels
enhancement New feature or request

Comments

@Shotokanman
Copy link

I am testing Goscan, which I really like so far. I loaded one IP and ran through the process. But I can’t load another IP or remove the previous IP, it shows the first IP. I can’t clear either. Is there a way to remove an IP once you have completed the goscan for that IP? Because of this issue, I am only able to use goscan once.

@marco-lancini
Copy link
Owner

Hi @Shotokanman, what happens if you try to load target ... again?

@marco-lancini marco-lancini added the question Further information is requested label Sep 4, 2020
@Shotokanman
Copy link
Author

Marco when I tried to load another IP, nothing happens. When I show targets, it contains the old ipaddress. I can't change it or load any new endpoints to scan.

@marco-lancini marco-lancini added bug Something isn't working enhancement New feature or request and removed question Further information is requested bug Something isn't working labels Sep 15, 2020
@marco-lancini
Copy link
Owner

I see, adding the ability to remove targets is an enhancement already requested in #14.
But we should definitely add the ability to add new targets as well.

If someone has some bandwidth to work on this it would be really helpful!

@PouuleT
Copy link

PouuleT commented Sep 28, 2020

Hello!
I have some bandwidth available and I'd love to give it a try if that's ok

A few question about the feature:

  • Which name would be better? "unload" / "delete" / "remove" ?
  • What kind of arguments should be accepted? Only the IP ?
  • What is the expected behaviour when you delete the target? does it also delete all the linked objects ( ports / hosts / services ) ?

@marco-lancini
Copy link
Owner

Hi @PouuleT, thank you for volunteering to help! 🙏

Regarding your questions:

Which name would be better? "unload" / "delete" / "remove" ?

What about unload?

What kind of arguments should be accepted? Only the IP ?

It would be good to mirror the behaviour of the load command, starting with the ability to remove only one single target.
Something like: unload target SINGLE <IP/32>

What is the expected behaviour when you delete the target? does it also delete all the linked objects ( ports / hosts / services ) ?

I think it would be easier to take an incremental approach, starting by removing just the target and then, in a future iteration, we could try to remove also all the linked objects. What do you think?

@PouuleT
Copy link

PouuleT commented Sep 29, 2020

I like the incremental approach! I'll go with unload target SINGLE <IP/32> which will only remove the target.
I'll try to make the PR before the end of the week

PouuleT added a commit to PouuleT/goscan that referenced this issue Oct 1, 2020
@PouuleT PouuleT linked a pull request Oct 1, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants