-
Notifications
You must be signed in to change notification settings - Fork 0
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: marceloboeira/confirm-before
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: marceloboeira/confirm-before
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 8 commits
- 5 files changed
- 1 contributor
Commits on Feb 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4691f53 - Browse repository at this point
Copy the full SHA 4691f53View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad308c2 - Browse repository at this point
Copy the full SHA ad308c2View commit details -
Answer the question on the same line
There is a small hack, we need to flush stdout since its usually updated based on newline frequency.
Configuration menu - View commit details
-
Copy full SHA for a770865 - Browse repository at this point
Copy the full SHA a770865View commit details -
Instead of spawning the command (which 'fails' for long running commands), wait for the command but pipe its stdout to the shell. If not, the bin finishes before the spawned command, which leads to a weird shell behavior, printing stuff after finishing.
Configuration menu - View commit details
-
Copy full SHA for c23bf3c - Browse repository at this point
Copy the full SHA c23bf3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb5293b - Browse repository at this point
Copy the full SHA fb5293bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c1c7ba - Browse repository at this point
Copy the full SHA 5c1c7baView commit details
Commits on Feb 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for bce848f - Browse repository at this point
Copy the full SHA bce848fView commit details
Commits on Jul 25, 2018
-
Fix #3 by printing to tty and not stdout
When you do something like > confirm-before echo "fooo" | grep foo Nothing was happening (apparently). Under the hood the grep commands consumes the stdout (where we print the "Are you sure?(y/n)"), then it keeps waiting for the stdin flush. Therefore, we need to write to tty instead of writing to stdout, otherwise grep suppress the output... it waits silently for the stdin input. We use termion to do that, simple and works fine. Unfortunately, I couldn't find an easy way to test for that... I accept suggestions.
Configuration menu - View commit details
-
Copy full SHA for 372415f - Browse repository at this point
Copy the full SHA 372415fView commit details
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.