Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider flex elements in incremental layout #1031

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

marc2332
Copy link
Owner

No description provided.

@marc2332 marc2332 added fix 🩹 Fixes a bug layout 📐 Relate to layout labels Dec 31, 2024
@marc2332 marc2332 added this to the 0.3.0 milestone Dec 31, 2024
Copy link

Benchmark for 30192d4

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 105.0±0.77ms 106.1±0.53ms +1.05%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 24.5±0.70ms 24.4±1.02ms -0.41%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1385.4±20.19µs 1397.2±62.52µs +0.85%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 134.8±3.72µs 135.3±1.68µs +0.37%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 24.2±0.78ms 24.0±1.03ms -0.83%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1688.8±24.09µs 1708.8±63.51µs +1.18%
benchmarks/size=19531 depth=7 wide=5 mode=cached 310.7±5.62µs 313.5±7.52µs +0.90%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.05ms 2.6±0.07ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 421.0±182.02µs 420.6±181.52µs -0.10%
benchmarks/size=54241 depth=5 wide=15 mode=cached 256.9±20.62µs 253.5±20.07µs -1.32%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.6±0.22ms 6.4±0.35ms -3.03%

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (05b7d57) to head (fc43861).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   74.78%   74.88%   +0.09%     
==========================================
  Files         219      219              
  Lines       25433    25532      +99     
==========================================
+ Hits        19020    19119      +99     
  Misses       6413     6413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332
Copy link
Owner Author

todo: some test

Copy link

github-actions bot commented Jan 5, 2025

Benchmark for d41318c

Click to view benchmark
Test Base PR %
benchmarks/alignments=true size=21845 depth=8 wide=4 mode=not cached 104.7±1.94ms 107.4±0.78ms +2.58%
benchmarks/size=100001 depth=2 wide=100000 mode=not cached 25.1±1.35ms 26.0±1.26ms +3.59%
benchmarks/size=10001 depth=2 wide=10000 mode=not cached 1393.4±17.95µs 1430.6±11.08µs +2.67%
benchmarks/size=1001 depth=2 wide=1000 mode=not cached 135.5±1.82µs 140.0±1.41µs +3.32%
benchmarks/size=131071 depth=17 wide=2 mode=not cached 25.2±0.72ms 24.5±0.59ms -2.78%
benchmarks/size=16383 depth=14 wide=2 mode=not cached 1701.6±21.36µs 1682.5±18.36µs -1.12%
benchmarks/size=19531 depth=7 wide=5 mode=cached 311.0±8.11µs 344.1±26.79µs +10.64%
benchmarks/size=19531 depth=7 wide=5 mode=not cached 2.6±0.03ms 2.6±0.04ms 0.00%
benchmarks/size=4095 depth=12 wide=2 mode=not cached 414.9±156.47µs 418.5±179.91µs +0.87%
benchmarks/size=54241 depth=5 wide=15 mode=cached 251.9±18.44µs 293.5±40.47µs +16.51%
benchmarks/size=54241 depth=5 wide=15 mode=not cached 6.5±0.20ms 6.3±0.16ms -3.08%

@marc2332 marc2332 marked this pull request as ready for review January 5, 2025 18:47
@marc2332 marc2332 merged commit baab869 into main Jan 8, 2025
8 checks passed
@marc2332 marc2332 deleted the fix/consider-flex-elements-in-incremental-layout branch January 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 Fixes a bug layout 📐 Relate to layout
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant