Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves websocket errors in tests #2525

Merged
merged 14 commits into from
Feb 17, 2025
Merged

resolves websocket errors in tests #2525

merged 14 commits into from
Feb 17, 2025

Conversation

CollinBeczak
Copy link
Collaborator

@CollinBeczak CollinBeczak commented Jan 31, 2025 •
edited
Loading

This pr resolves websocket error in tests, and also resolves some componentMounting issue highlighted in tests.

@CollinBeczak CollinBeczak requested a review from jake-low January 31, 2025 19:38
@CollinBeczak CollinBeczak marked this pull request as draft January 31, 2025 20:31
@CollinBeczak CollinBeczak marked this pull request as ready for review January 31, 2025 23:14
@CollinBeczak CollinBeczak removed the request for review from jake-low February 1, 2025 00:06
@CollinBeczak CollinBeczak marked this pull request as draft February 1, 2025 00:06
@jake-low jake-low mentioned this pull request Feb 1, 2025
Merged
@CollinBeczak CollinBeczak changed the title fix challenge creation and input bugs resolves websocket errors in tests Feb 15, 2025
@CollinBeczak CollinBeczak force-pushed the fix-challenge-create-and-input-bugs branch from e500d10 to 30cd09d Compare February 15, 2025 19:01
@CollinBeczak CollinBeczak marked this pull request as ready for review February 17, 2025 16:02
jake-low
jake-low approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@jake-low jake-low left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@CollinBeczak CollinBeczak merged commit a8c9849 into main Feb 17, 2025
6 checks passed
@CollinBeczak CollinBeczak deleted the fix-challenge-create-and-input-bugs branch February 17, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake-low jake-low jake-low approved these changes

@jschwarz2030 jschwarz2030 Awaiting requested review from jschwarz2030

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CollinBeczak @jake-low