Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix infinite loop when inspecting task after challenge save #2276

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Fixes the infinite loop of fetching tasks caused by a condition in a componentDidUpdate being true always after a challenge is saved.
Screenshot 2024-02-19 at 9 21 14 PM

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ac6c97f) 23.58% compared to head (e0b43f1) 23.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
...ents/HOCs/WithFilterCriteria/WithFilterCriteria.js 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2276   +/-   ##
=======================================
  Coverage   23.58%   23.58%           
=======================================
  Files         648      648           
  Lines       22497    22498    +1     
  Branches     6954     6954           
=======================================
+ Hits         5306     5307    +1     
  Misses      14373    14373           
  Partials     2818     2818           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak merged commit c5c8385 into main Feb 20, 2024
5 checks passed
@CollinBeczak CollinBeczak deleted the fixInfiniteOnSaveLoop branch February 20, 2024 03:31
@CollinBeczak CollinBeczak mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants