Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation issue/error in challenge editor #2275

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

AndrewPhilbin
Copy link
Contributor

Fixes a problem where failing form validation on submit for any reason in the long form view would then prevent any progress if subsequently switching to the short form view by triggering the same submit error.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ac6c97f) 23.58% compared to head (285fee1) 23.58%.
Report is 2 commits behind head on main.

Files Patch % Lines
...ge/ManageChallenges/EditChallenge/EditChallenge.js 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2275      +/-   ##
==========================================
- Coverage   23.58%   23.58%   -0.01%     
==========================================
  Files         648      648              
  Lines       22497    22498       +1     
  Branches     6954     6955       +1     
==========================================
  Hits         5306     5306              
  Misses      14373    14373              
- Partials     2818     2819       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak merged commit a019b69 into main Feb 20, 2024
5 checks passed
@CollinBeczak CollinBeczak deleted the challenge-form-validation-fix branch February 20, 2024 00:40
@CollinBeczak CollinBeczak mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants