Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create challenge form's next button functionality #2271

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

CollinBeczak
Copy link
Collaborator

Issue fixed: User was unable to get past instructions in the paged challenge editor.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (97d6a4a) 23.58% compared to head (32a6a39) 23.58%.
Report is 2 commits behind head on main.

Files Patch % Lines
...lenges/EditChallenge/Schemas/InstructionsSchema.js 11.11% 4 Missing and 4 partials ⚠️
...ge/ManageChallenges/EditChallenge/EditChallenge.js 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2271      +/-   ##
==========================================
- Coverage   23.58%   23.58%   -0.01%     
==========================================
  Files         648      648              
  Lines       22497    22505       +8     
  Branches     6953     6956       +3     
==========================================
+ Hits         5307     5308       +1     
- Misses      14373    14377       +4     
- Partials     2817     2820       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…idation, now coercing .env CHALLENGE_INSTRUCTIONS_MIN_LENGTH to number value in instructions schema
@mvexel
Copy link
Member

mvexel commented Feb 16, 2024

Thanks for the quick fix!

@AndrewPhilbin AndrewPhilbin marked this pull request as draft February 19, 2024 22:57
@AndrewPhilbin AndrewPhilbin marked this pull request as ready for review February 19, 2024 23:21
@CollinBeczak CollinBeczak merged commit 385e413 into main Feb 20, 2024
5 checks passed
@CollinBeczak CollinBeczak deleted the updateFormNextButton branch February 20, 2024 00:16
@CollinBeczak CollinBeczak mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants