Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter clearing for Task Tables #2253

Merged
merged 8 commits into from
Feb 13, 2024
Merged

Conversation

AndrewPhilbin
Copy link
Contributor

Adds ability to both clear all applied filters in the Task Review Table view and to clear table column filters individually, where reasonable to do so, in both the Review and Analysis table views. Fixes some minor styling issues with button layouts and dropdown menus not autoclosing in certain circumstances.

Screen Shot 2024-01-23 at 1 48 14 PM

Screen Shot 2024-01-23 at 1 49 20 PM

@AndrewPhilbin AndrewPhilbin marked this pull request as draft January 23, 2024 22:42
@AndrewPhilbin AndrewPhilbin marked this pull request as ready for review January 24, 2024 02:21
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 61 lines in your changes are missing coverage. Please review.

Comparison is base (35f598a) 23.66% compared to head (9cce77b) 23.64%.
Report is 15 commits behind head on main.

Files Patch % Lines
src/pages/Review/TasksReview/TasksReviewTable.js 6.81% 40 Missing and 1 partial ⚠️
...onents/KeywordAutosuggestInput/InTableTagFilter.js 0.00% 6 Missing and 1 partial ⚠️
.../components/TaskAnalysisTable/TaskAnalysisTable.js 62.50% 3 Missing ⚠️
...nents/TaskAnalysisTable/TaskAnalysisTableHeader.js 0.00% 3 Missing ⚠️
...components/HOCs/WithReviewTasks/WithReviewTasks.js 0.00% 2 Missing ⚠️
src/components/SavedFilters/SavedFiltersList.js 0.00% 2 Missing ⚠️
src/pages/Review/Review.js 0.00% 2 Missing ⚠️
src/services/Search/Search.js 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
- Coverage   23.66%   23.64%   -0.03%     
==========================================
  Files         648      648              
  Lines       22379    22432      +53     
  Branches     6905     6923      +18     
==========================================
+ Hits         5297     5304       +7     
- Misses      14282    14327      +45     
- Partials     2800     2801       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CollinBeczak CollinBeczak merged commit 5359317 into main Feb 13, 2024
5 checks passed
@CollinBeczak CollinBeczak deleted the task-table-filter-clearing branch February 13, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants