add link previews #2251
Merged
add link previews #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2251 +/- ##
==========================================
- Coverage 23.66% 23.66% -0.01%
==========================================
Files 648 648
Lines 22379 22380 +1
Branches 6905 6905
==========================================
Hits 5297 5297
- Misses 14282 14283 +1
Partials 2800 2800 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2248
Resolves: #1755
There are some interesting discoveries with this PR. There is a library called react-helmet, this library can be used to add meta tags to the of the page dynamically. However, there is a problem when using it for creating meta tags for link previews. The issue being that the tags are added after the initial render, and websites only look at the initial render to get the meta tags for the link previews. So for now, this PR sets up static link previews until we can find a solution to create dynamic meta tags on the initial render.