Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance docs for New Contributors #1677

Open
2 tasks
sharkAndshark opened this issue Feb 2, 2025 · 3 comments
Open
2 tasks

Enhance docs for New Contributors #1677

sharkAndshark opened this issue Feb 2, 2025 · 3 comments

Comments

@sharkAndshark
Copy link
Collaborator

sharkAndshark commented Feb 2, 2025

  • Check the installation of tools used in test.sh (jq file..). Originally suggested by @CommanderStorm
  • Document How to work with just to test, to preview and build martin book, etc... in development.md (or maybe a new file)
@sharkAndshark sharkAndshark changed the title chore: Enhance Contributing Guidelines for New Contributors Enhance Contributing Guidelines for New Contributors Feb 2, 2025
@nyurik
Copy link
Member

nyurik commented Feb 3, 2025

do we really want to have the starting script as a bash test.sh? I think some just recipes would be sufficient to do any kind of validation. We could even hack together a validation of just itself using {{just_executable()}} --version and to check if it is too old using semver_matches() just function:

{{semver_matches(shell(just_executable(), '--version'), ">1.38")}}

P.S. see also casey/just#2616

@sharkAndshark
Copy link
Collaborator Author

Just recipe better

@sharkAndshark sharkAndshark changed the title Enhance Contributing Guidelines for New Contributors Enhance docs for New Contributors Feb 3, 2025
@jjcfrancisco
Copy link

This is great guys. I'd be keen to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants