feat(events): check if event instanceof MouseEvent #5466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
from
015fb5f to
6370d49
Compare
HarelM
reviewed
Feb 5, 2025
HarelM
reviewed
Feb 5, 2025
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
from
6370d49 to
21c439e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5466 +/- ##
==========================================
+ Coverage 91.96% 91.99% +0.03%
==========================================
Files 282 282
Lines 39050 39086 +36
Branches 6855 6868 +13
==========================================
+ Hits 35911 35956 +45
+ Misses 3012 3001 -11
- Partials 127 129 +2 ☔ View full report in Codecov by Sentry. |
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
3 times, most recently
from
46694f8 to
1316f24
Compare
HarelM
reviewed
Feb 6, 2025
ToHold
commented
Feb 6, 2025
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
from
1316f24 to
640cb5c
Compare
ToHold
commented
Feb 10, 2025
HarelM
reviewed
Feb 11, 2025
HarelM
reviewed
Feb 11, 2025
HarelM
reviewed
Feb 11, 2025
HarelM
reviewed
Feb 11, 2025
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
from
640cb5c to
b11844f
Compare
|
Tests were ok in local, I will check during the day why it fails. |
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
2 times, most recently
from
5a8bccd to
58ed29e
Compare
check if event is instance of MouseEvent in map_event.ts same for event.ts Fix 5464
ToHold
force-pushed
the
feat-check-if-event-instanceof-MouseEvent
branch
from
58ed29e to
36eadfd
Compare
|
Should I update the bundle size test, or will a collaborator handle it? |
|
Please update the build size. Thanks! |
HarelM
reviewed
Feb 13, 2025
| return pointableEvents[eventType] && (event instanceof MouseEvent || event instanceof WheelEvent); | ||
| } | ||
|
|
||
| export function isTouchableOrPointableType(eventType: string): boolean { |
There was a problem hiding this comment.
Not sure I fully see the value of this method, when used it is in an "if" statement that a simple else cover, doesn't it?
HarelM
reviewed
Feb 13, 2025
|
|
||
| const pointableEvents = { | ||
| dblclick: true, | ||
| click: true, |
There was a problem hiding this comment.
Click can be achieved in touch devices, can't it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an error that could happen if a instance of Event is dispatched with MouseEvent types. This error has been encountered only when bots were crawling a website where a maplibre map was instanced.
Launch Checklist
CHANGELOG.mdunder the## mainsection.