Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mapbox gl draw example #5393

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

andrewharvey
Copy link
Contributor

Launch Checklist

As raised via a comment in #5138, the mapbox-gl-draw example currently provides an example of using mapbox-gl-draw however the description mentioned maplibre-gl-draw.

This PR updates the description to match the example given.

We also update to mapbox-gl-draw 1.5.0 since from this version the CANVAS class is exposed which we need to override to match the maplibre class. This is necessary for the delete a vertex feature to work and possibly other features.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Add an entry to CHANGELOG.md under the ## main section.

Is this done for examples as well?

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.95%. Comparing base (3f28408) to head (7f36c9f).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5393   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files         282      282           
  Lines       38908    38908           
  Branches     6820     6827    +7     
=======================================
  Hits        35777    35777           
  Misses       3003     3003           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This will be available when the next release goes out.

@HarelM HarelM merged commit c151bf3 into maplibre:main Jan 23, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants