Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unminified prod build (Revert #4265) #4906

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

birkskyum
Copy link
Member

@birkskyum birkskyum commented Oct 26, 2024

This unminified-prod build was introduce in june to accommodate Plotly.js.

Unfortunately, because of problems with sourcemaps the ploly.js team, the only known users of the bundle, ended up using the normal prod build maplibre-gl.js

Therefore, we can safely remove the unminified prod from maplibre v5.

@birkskyum birkskyum added this to the 5.0 milestone Oct 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.29%. Comparing base (491ac04) to head (8b24b2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4906      +/-   ##
==========================================
+ Coverage   87.99%   90.29%   +2.29%     
==========================================
  Files         265      265              
  Lines       37974    37974              
  Branches     2409     2539     +130     
==========================================
+ Hits        33417    34290     +873     
+ Misses       3490     2827     -663     
+ Partials     1067      857     -210     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@birkskyum birkskyum changed the title Remove unminified production build Revert: Publish an unminified prod build Oct 26, 2024
@birkskyum birkskyum changed the title Revert: Publish an unminified prod build Stop publishing unminified prod build (Revert #4265) Oct 26, 2024
@birkskyum birkskyum changed the title Stop publishing unminified prod build (Revert #4265) Remove unminified prod build (Revert #4265) Oct 26, 2024
@HarelM HarelM merged commit 3346fbd into maplibre:main Oct 27, 2024
15 checks passed
@NathanMOlson
Copy link
Contributor

@birkskyum is there an alternative to build-prod-unminified? I've been using it to debug the unminified source code in a browser.

@birkskyum
Copy link
Member Author

birkskyum commented Nov 4, 2024

@NathanMOlson , there's the maplibre-gl-dev bundle, made with the build-dev, which doesn't minify. If you have a terminal running the npm run start in the background, it'll watch the files and let you somewhat fast try new changes in the browser, and it's the dev build that the render test uses in puppeteer, you can also quite fast iterate with the render test. Does that work for you?

@NathanMOlson
Copy link
Contributor

@birkskyum that would work for me, but it appears that maplibre-gl-dev.js is now being minified :(

@birkskyum birkskyum mentioned this pull request Nov 4, 2024
1 task
@birkskyum
Copy link
Member Author

birkskyum commented Nov 4, 2024

@NathanMOlson , until #4989 is merged, you can apply the fix manually. Does that work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants