-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unminified prod build (Revert #4265) #4906
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4906 +/- ##
==========================================
+ Coverage 87.99% 90.29% +2.29%
==========================================
Files 265 265
Lines 37974 37974
Branches 2409 2539 +130
==========================================
+ Hits 33417 34290 +873
+ Misses 3490 2827 -663
+ Partials 1067 857 -210 ☔ View full report in Codecov by Sentry. |
@birkskyum is there an alternative to |
@NathanMOlson , there's the |
@birkskyum that would work for me, but it appears that |
@NathanMOlson , until #4989 is merged, you can apply the fix manually. Does that work for you? |
This unminified-prod build was introduce in june to accommodate Plotly.js.
Unfortunately, because of problems with sourcemaps the ploly.js team, the only known users of the bundle, ended up using the normal prod build
maplibre-gl.js
mablibre
source map plotly/plotly.js#7204Therefore, we can safely remove the unminified prod from maplibre v5.