Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back slider component #626

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add back slider component #626

merged 2 commits into from
Feb 3, 2025

Conversation

oscarlorentzon
Copy link
Member

Motivation

Keep feature parity with v4.x

Contribution

  • Add back slider component.
  • Use original implementation, do not adapt to library changes like shader API.
  • This PR introduces duplication and increases the bundle size.

Test Plan

yarn build
yarn test
yarn start

@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Feb 3, 2025
@oscarlorentzon oscarlorentzon self-assigned this Feb 3, 2025
@oscarlorentzon oscarlorentzon merged commit 67f847d into main Feb 3, 2025
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-slider branch February 3, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot